Fixes a couple of bugs related to UTC offsets and day-counting. #569
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mgwalker
commented
Jan 16, 2025
|
|
||
| module.exports = (robot) => { | ||
| robot.message(/evermarch/i, ({ message, say }) => { | ||
| const now = moment.tz("America/New_York"); | ||
|
|
||
| const days = Math.ceil(moment.duration(now.diff(march1)).as("days")); | ||
| const days = now.diff(march1, "days") + 1; |
There was a problem hiding this comment.
Calculate the diff as days instead of as milliseconds. This will take leap years and stuff into account. Then add one because the diff between March 1 and March 1 is 0 days, but it's the 1st of March.
Comment on lines
+30
to
+32
| jest.setSystemTime( | ||
| moment.tz("2020-03-02T00:00:00", "America/New_York").toDate(), | ||
| ); |
There was a problem hiding this comment.
Tests should be in eastern time too. And once we switch to calculating whole day diffs, we don't need the little offset to make things work. They just work!
Comment on lines
-75
to
+116
| jest.setSystemTime(Date.parse("2025-09-10T12:00:00Z")); | ||
| jest.setSystemTime( | ||
| moment.tz("2025-09-10T00:00:00", "America/New_York").toDate(), | ||
| ); |
There was a problem hiding this comment.
The reason this one used to have to be at noon in order to pass is, I think, because of issues with DST. The old millisecond-based diff was bound to drift over time, which we don't really want. So now we don't do it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Evermarch script mistakenly calculated time from March 1, 2020, midnight UTC, instead of midnight America/New_York as intended. Additionally, it was calculating the time difference in milliseconds and then dividing that into a number of days, which meant it was not accounting for leap years or DST.
Checklist:
N/A:
page has been updated if Charlie needs any new OAuth events or scopes
wiki page has been updated if new environment variables were introduced
or existing ones changed