Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BaseSpider references geolocation args before defining it #49

Open
VMRuiz opened this issue Apr 11, 2024 · 2 comments
Open

BaseSpider references geolocation args before defining it #49

VMRuiz opened this issue Apr 11, 2024 · 2 comments

Comments

@VMRuiz
Copy link
Contributor

VMRuiz commented Apr 11, 2024

BaseSpider is referencing geolocation argument here while is not defined yet. That makes impossible to re-use this class without using the geolocation parameter:

@Gallaecio
Copy link
Contributor

Same for max_requests.

@kmike
Copy link
Contributor

kmike commented Dec 14, 2024

Geolocation seems to be handled better now:

if geolocation := getattr(spider.args, "geolocation", None):

But the issue still applies for max_requests.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants