Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove (?) mostly-redundant recipient headers in DM narrow #1244

Open
chrisbobbe opened this issue Jan 2, 2025 · 5 comments
Open

Remove (?) mostly-redundant recipient headers in DM narrow #1244

chrisbobbe opened this issue Jan 2, 2025 · 5 comments
Labels
a-msglist The message-list screen, except what's label:a-content
Milestone

Comments

@chrisbobbe
Copy link
Collaborator

chrisbobbe commented Jan 2, 2025

Much like an issue for topic narrows:

but this is for DM narrows. Currently it looks like this:

Many messages Few messages

We have a design from Vlad showing the many-messages case:

https://www.figma.com/design/1JTNtYo9memgW7vV6d0ygq/Zulip-Mobile?node-id=4933-16071&m=dev
image

which looks like it just removes the recipient headers. Perhaps we should do that, but first let's consider some design questions Greg raised for topic narrows in #1039 (comment) which seem equally relevant to DM narrows:

Design questions we'll want to resolve before implementing this include:

  • Have an example where the thread is shorter than the screen, so there's empty space between the app bar and the first message; make sure we're happy with how that looks, or adjust something. (Possibly switch to pinning the earliest message at the top instead of the latest at the bottom, so the empty space goes between the last message and the compose box.)
  • Decide how to handle showing the messages' dates, which currently live in the recipient header.

cc @terpimost for those design questions.

@chrisbobbe chrisbobbe added the a-msglist The message-list screen, except what's label:a-content label Jan 2, 2025
@chrisbobbe chrisbobbe added this to the M7: Future milestone Jan 2, 2025
@chrisbobbe
Copy link
Collaborator Author

Milestoning M7: Future to match #1039.

@alya
Copy link
Collaborator

alya commented Jan 2, 2025

Related discussion

@terpimost
Copy link

example where the thread is shorter than the screen

I updated Figma with this example:
image

I thought that messages are just stick to top unless they are longer than available screen + some gutter (min 8px) and then just scroll.

Decide how to handle showing the messages' dates

We discussed that with @gnprice and thought that consequent messages date and times are not that important to have always be displayable, so decision is to show them in the context menu, where we see message preview with an author always:
image

Figma area about this

@gnprice
Copy link
Member

gnprice commented Jan 3, 2025

Thanks for the update!

I think the second part of your comment is about #457, or an alternative that we'll do instead of #457. But my second question was about the dates, not the times. I don't see a date in your second screenshot.

@terpimost
Copy link

terpimost commented Jan 4, 2025

Oh, sorry. Do you guys talk about this case?
image

And there is nothing above...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
a-msglist The message-list screen, except what's label:a-content
Projects
Status: No status
Development

No branches or pull requests

4 participants