Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UI for channel subscription settings other than muted/unmuted #1223

Open
4 tasks
chrisbobbe opened this issue Dec 27, 2024 · 2 comments
Open
4 tasks

UI for channel subscription settings other than muted/unmuted #1223

chrisbobbe opened this issue Dec 27, 2024 · 2 comments
Labels
beta feedback Things beta users have specifically asked for

Comments

@chrisbobbe
Copy link
Collaborator

chrisbobbe commented Dec 27, 2024

Probably a followup to:

Here's my thought for what's highest priority of these settings, copy-pasting from the API doc:

  • "is_muted": (tracked already in UI for channel muting/unmuting #347)
  • "pin_to_top": Whether to pin the channel at the top of the channel list.
  • "push_notifications": Whether to trigger a mobile push notification for all messages sent to the channel.
  • "wildcard_mentions_notify": Whether wildcard mentions trigger notifications as though they were personal mentions in this channel.

I think a "channel action sheet", in the style of the existing topic action sheet, is a fine place for these per-user-per-channel settings to go.

The other settings (lower priority IMO) are:

  • "color": The hex value of the user's display color for the channel.
  • "desktop_notifications": Whether to show desktop notifications for all messages sent to the channel.
  • "audible_notifications": Whether to play a sound notification for all messages sent to the channel. [is mobile supposed to use this setting? isn't this controlled in mobile device-level notification settings?]
  • "email_notifications": Whether to trigger an email notification for all messages sent to the channel.

Related issues:

@chrisbobbe
Copy link
Collaborator Author

This came up in beta feedback on CZO; noting it here because this issue covers muting and notifications:

In the new app, I don't see any way to unsubscribe / mute / notifications / add subscriber.

@gnprice
Copy link
Member

gnprice commented Dec 28, 2024

The legacy app offers these first three settings:

  • "is_muted": (tracked already in UI for channel muting/unmuting #347)
  • "pin_to_top": Whether to pin the channel at the top of the channel list.
  • "push_notifications": Whether to trigger a mobile push notification for all messages sent to the channel.

but not the others.

  • "audible_notifications": Whether to play a sound notification for all messages sent to the channel. [is mobile supposed to use this setting? isn't this controlled in mobile device-level notification settings?]

Yeah, this sounds like it controls the behavior of desktop notifications.

@gnprice gnprice added this to the M6: Post-launch milestone Dec 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
beta feedback Things beta users have specifically asked for
Projects
Status: No status
Development

No branches or pull requests

2 participants