home: Stop assuming account existence from loading page #1235
Conversation
We could pass realmUrl when initializing the `_LoadingPlaceholderPage`, but that will still require a check for the existence of the account. The loading page will be blank when the account does not exist. The user can't easily reach this page because they can only logout from `ChooseAccountPage`, until we start invalidating API keys. Even then, they will only see the blank page briefly before getting navigated, so we should not show any text at all. Fixes: zulip#1219 Signed-off-by: Zixuan James Li <[email protected]>
|
Not sure if we still show the loading indicator there, though. This page can be visible for a frame only after #737, but if we don't have the realmUrl, there will potentially be a layout shift as the circular indicator's position is affected by the hidden text. Because |
Yeah, that's a fine reason to leave out the loading indicator. It's probably less jarring to have it disappear while the page is animating out than to have it suddenly shift while the page is animating out. Note it's more than a frame — the animation duration for leaving a page is more like 200ms. |
We could pass realmUrl when initializing the
_LoadingPlaceholderPage, but that will still require a check for the existence of the account.The loading page will be blank when the account does not exist. The user can't easily reach this page because they can only logout from
ChooseAccountPage, until we start invalidating API keys. Even then, they will only see the blank page briefly before getting navigated, so we should not show any text at all.Screenshot
Fixes: #1219