Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Using the leaky bucket strategy, how to cap the value of the counter? #31

Open
acrispino opened this issue Mar 10, 2018 · 1 comment
Open

Using the leaky bucket strategy, how to cap the value of the counter? #31

acrispino opened this issue Mar 10, 2018 · 1 comment

Comments

@acrispino
Copy link

No description provided.

@ctuong
Copy link

ctuong commented Nov 1, 2018

Are you referring to the fact that the counter continues to be incremented in the cache even if the burst_rate has already been exceeded? If so, I agree that the counter should only be incremented in the cache if the counter + increment_value does not exceed the burst_rate, otherwise it should just return true (for throttled?).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ctuong @acrispino