Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update webapp.rb to allow for proxies #298

Open
nc-williambr opened this issue Dec 31, 2024 · 4 comments
Open

Update webapp.rb to allow for proxies #298

nc-williambr opened this issue Dec 31, 2024 · 4 comments
Assignees
Milestone

Comments

@nc-williambr
Copy link

I believe a change upstream may have changed the handling of connection restrictions.

Per this comment in ytti/oxidized, I suggest updating webapp.rb with the following line:

set :host_authorization, { permitted_hosts: [] }

@robertcheramy
Copy link
Collaborator

This was introduced in Sinatra 4.1.0

This interesting, as the problem should occur only in a development environment.

We do not set the APP_ENV environment variable, so we get the default: development.

@einsibjarni
Copy link

We run oxidized-web behind a proxy and this is a problem for us as well

@robertcheramy
Copy link
Collaborator

Note - this does not happen with the official oxidized container, as it uses sinatra from ubuntu noble, which is Version 3.0.5.

@robertcheramy
Copy link
Collaborator

The solution is probably to start oxidized with APP_ENV=production oxidized.
As I cannot reproduce, I cannot test it.
This Issue is being worked on in the oxidized issue 3340

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants