Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Invalid option error when it's in fact a missing xmake.lua #6026

Open
A2va opened this issue Dec 31, 2024 · 0 comments
Open

Invalid option error when it's in fact a missing xmake.lua #6026

A2va opened this issue Dec 31, 2024 · 0 comments
Labels

Comments

@A2va
Copy link
Contributor

A2va commented Dec 31, 2024

Xmake Version

v2.9.5+dev.478972cd9

Operating System Version and Architecture

Windows 10

Describe Bug

To reproduce the bug, clone the xmake repository but do not checkout the submodules, then try to enable a project-specific config that is not part of the default one.

xmake\core> xmake f -p windows --embed=true 
Error: Invalid option: --embed=true

I think it's because xmake knows there's another sub xmake.lua that it doesn't validate the embed option.
If the embed config is now removed from the command:

xmake\core> xmake f -p windows --embed=true 
Error: file(D:\Dev\xmake\core\src\sv\sv\xmake.lua): file not found!

Now, as a user, I know that something is missing in that directory, but before I just couldn't predict that was the root cause.

Expected Behavior

The best behavior would be to show only error: file(D:\Dev\xmake\core\src\sv\xmake.lua): file not found! and not the invalid option. However, if it's too much work, it's best to show both errors.

Project Configuration

https://github.com/xmake-io/xmake/blob/dev/core/xmake.lua

Additional Information and Error Logs

Nothing relevant to share

@A2va A2va added the bug label Dec 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant