From 8be9715790e20a6be42f2e73a09de0242b0e6086 Mon Sep 17 00:00:00 2001
From: Felix Zumstein <fzumstein@gmail.com>
Date: Sun, 8 Dec 2024 22:45:08 +0100
Subject: [PATCH] fix function namespace if empty (#201)

* fix function namespace if empty

* fix tests
---
 app/templates/manifest.xml    |  4 ++++
 tests/test_router_manifest.py | 10 ++--------
 2 files changed, 6 insertions(+), 8 deletions(-)

diff --git a/app/templates/manifest.xml b/app/templates/manifest.xml
index 0b0351de..d6aa3a20 100644
--- a/app/templates/manifest.xml
+++ b/app/templates/manifest.xml
@@ -46,7 +46,9 @@
             <Metadata>
               <SourceLocation resid="Functions.Metadata.Url" />
             </Metadata>
+            {% if settings.functions_namespace %}
             <Namespace resid="Functions.Namespace" />
+            {% endif %}
           </ExtensionPoint>
         </AllFormFactors>
 
@@ -125,7 +127,9 @@
         <bt:Url id="Functions.Metadata.Url" DefaultValue="{{ base_url_with_app_path }}/xlwings/custom-functions-meta.json" />
       </bt:Urls>
       <bt:ShortStrings>
+        {% if settings.functions_namespace %}
         <bt:String id="Functions.Namespace" DefaultValue="{{ settings.functions_namespace|upper }}{{ '_' if settings.functions_namespace and settings.environment != 'prod'}}{{ settings.environment | upper if settings.environment != 'prod'}}" />
+        {% endif %}
         <bt:String id="MyTab.TabLabel" DefaultValue="{{ settings.project_name }}{{ ' [' + settings.environment + ']' if settings.environment != 'prod'}}" />
         <bt:String id="MyCommandsGroup.Label" DefaultValue="MyGroup" />
         <bt:String id="MyFunctionButton.Label" DefaultValue="Hello World" />
diff --git a/tests/test_router_manifest.py b/tests/test_router_manifest.py
index ec1c4c20..e63c025d 100644
--- a/tests/test_router_manifest.py
+++ b/tests/test_router_manifest.py
@@ -28,17 +28,11 @@ def test_get_manifest_prod(mocker):
     )
 
 
-def test_empty_function_namespace_prod(mocker):
+def test_empty_function_namespace(mocker):
     mocker.patch.object(settings, "environment", "prod")
     mocker.patch.object(settings, "functions_namespace", "")
     response = client.get(f"{settings.app_path}/manifest")
-    assert '<bt:String id="Functions.Namespace" DefaultValue="" />' in response.text
-
-
-def test_empty_function_namespace_nonprod(mocker):
-    mocker.patch.object(settings, "functions_namespace", "")
-    response = client.get(f"{settings.app_path}/manifest")
-    assert '<bt:String id="Functions.Namespace" DefaultValue="QA" />' in response.text
+    assert "Functions.Namespace" not in response.text
 
 
 def test_entraid_auth_deactivated():