Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Testcontainers Node.js module for WireMock #10

Open
1 of 5 tasks
oleg-nenashev opened this issue Apr 21, 2023 · 8 comments
Open
1 of 5 tasks

Testcontainers Node.js module for WireMock #10

oleg-nenashev opened this issue Apr 21, 2023 · 8 comments
Assignees
Labels
enhancement New feature or request help wanted Extra attention is needed javascript Integrations for Javascript testcontainers This task is related to Testcontainers integrations or demos

Comments

@oleg-nenashev
Copy link
Member

oleg-nenashev commented Apr 21, 2023

Proposal

Similar to Java, it would be nice to add support for starting the WireMock server using Testcontainers when Docker is present and no other WireMock server has been provided

Preview

Scope

If there are any existing implementations, prototypes, blogs or etc, let us know!

There is WireMock Captain implementation for JavaScript and TypeScript based on WireMock Docker, but not a Testcontainers one. See the WireMock Ecosystem listing for the references

Reference any relevant documentation, other materials or issues/pull requests that can be used for inspiration.

@oleg-nenashev oleg-nenashev added enhancement New feature or request javascript Integrations for Javascript labels Apr 21, 2023
@kurayami07734
Copy link

I would like to work on this

@oleg-nenashev
Copy link
Member Author

@kurayami07734 It would be great, thanks for your interest! I suggest starting in your personal repository which we could transfer to the WireMock org once the prototype is ready

@oleg-nenashev oleg-nenashev added testcontainers This task is related to Testcontainers integrations or demos help wanted Extra attention is needed labels Oct 9, 2023
@kurayami07734
Copy link

That's fine but, it would not count as a pull request right?

@oleg-nenashev
Copy link
Member Author

@kurayami07734 Fair point. I will create a repository

@oleg-nenashev
Copy link
Member Author

@kurayami07734 Created https://github.com/wiremock/wiremock-testcontainers-node for you

@kurayami07734
Copy link

I think we can close this issue now

@oleg-nenashev oleg-nenashev moved this from Backlog to 🏎️ In Progress in 🛣️ WireMock Public Roadmap Oct 16, 2023
@oleg-nenashev
Copy link
Member Author

@kurayami07734 definitely not closed until released in preview/GA and made available to users. But yes many patches can come in subsequent pull requests

@oleg-nenashev
Copy link
Member Author

@kurayami07734 I added the acceptance criteria here for better clarity what we'd need to have in the end. It can be done incrementally

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request help wanted Extra attention is needed javascript Integrations for Javascript testcontainers This task is related to Testcontainers integrations or demos
Projects
Development

No branches or pull requests

2 participants