Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement fit of ScienceEnsemble and use in DVC #135

Open
nsorros opened this issue Nov 2, 2021 · 0 comments
Open

Implement fit of ScienceEnsemble and use in DVC #135

nsorros opened this issue Nov 2, 2021 · 0 comments
Labels

Comments

@nsorros
Copy link
Contributor

nsorros commented Nov 2, 2021

At the moment the models trained for science ensemble are trained independently. Since there is a model class ScienceEnsemble the training should move inside fit which will simplify dvc.yaml as well. Note that save will also need to be implemented.

There are two ways for implementing that

  • through the use of WellcomeVotingClassifier which would be ideal
  • through training the classifier independently inside fit and saving them

The WellcomeVotingClassifier might not be possible due to some internals of sklearn but we should investigate whether it makes sense to adjust the code to ensure it works. tfidf-svm is already an sklearn pipeline so any problems will probably arise from BertClassifier

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant