Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Makefile changes (tox and dist) #40

Open
lizgzil opened this issue Aug 6, 2020 · 0 comments
Open

Makefile changes (tox and dist) #40

lizgzil opened this issue Aug 6, 2020 · 0 comments

Comments

@lizgzil
Copy link
Contributor

lizgzil commented Aug 6, 2020

After debugging an issue with keras with @jdu, Jeff suggested we need to redesign some parts of how the tests are run.

  • We shouldnt be using a virtualenv with tox where you pre-install a requirements.txt. tox creates a virtualenv from the venv you instantiate in the repo. This means that any site-packages are copied into the new venv that tox creates for testing purposes. Basically tox tears down its virtualenvs it creates on each run, but if the venv is based on another venv, it will copy site-packages installed from the parent venv, so when you run tox this way you’re not actually doing a fresh clean install of the package.
  • We need to fix that Makefile so that you DO NOT overwrite existing referenced versions of the deep_reference_parser wheel/pkg so that changes to the package don’t break existing processes depending on it.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant