-
-
Notifications
You must be signed in to change notification settings - Fork 156
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Source Map is inorrect when enable extractComments.banner of terser-webpack-plugin #589
Comments
I will look soon at this |
Thanks |
any progress? |
Still in my TODO, a lot of issue, if you have a time feel free to investigate and send a PR |
stephenliang
added a commit
to code-dot-org/code-dot-org
that referenced
this issue
Jul 26, 2024
`extractcomments` is enabled by default but appears to have a bug which breaks source maps. This bug causes an incorrect reference to `types.ts` which causes source maps to not be useful at all. Disabling `extractComments` appears to be the workaround to use until terser fixes on their end. ref: webpack-contrib/terser-webpack-plugin#589
Merged
8 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Bug report
webpack-terser-bug
What is the current behavior?
When my project using json file and
[email protected]
, the source map is incorrect:Find
a.json
is mapped touse-sync-external-store
incorrectly.What is the expected behavior?
When disable
extractComments
options ofterser-webpack-plugin
,the behavior is correct.a.json
is no-source, this is expected.Other relevant information:
webpack version: 5.89.0
Node.js version: v18.18.0
Operating System: MacOS m2
The text was updated successfully, but these errors were encountered: