From 424108b9ed0358ced9f9371921fb97b4f36199f3 Mon Sep 17 00:00:00 2001 From: Sam Sneddon Date: Thu, 2 Nov 2023 00:16:24 +0000 Subject: [PATCH 1/3] Fix #3009: unable to search for mixed case filenames --- webapp/components/test-search.js | 2 +- webapp/components/test/test-search.html | 20 ++++++++++++++++++++ 2 files changed, 21 insertions(+), 1 deletion(-) diff --git a/webapp/components/test-search.js b/webapp/components/test-search.js index 2405372e41..c3638e064f 100644 --- a/webapp/components/test-search.js +++ b/webapp/components/test-search.js @@ -510,7 +510,7 @@ class TestSearch extends WPTFlags(PolymerElement) { } latchQuery() { - this.query = (this.queryInput || '').toLowerCase(); + this.query = (this.queryInput || ''); } commitQuery() { diff --git a/webapp/components/test/test-search.html b/webapp/components/test/test-search.html index 6355d5d62a..ad09b0d643 100644 --- a/webapp/components/test/test-search.html +++ b/webapp/components/test/test-search.html @@ -17,6 +17,7 @@ From 76d8c9f7d9812d0c42c3696e81478e5d89164f32 Mon Sep 17 00:00:00 2001 From: Sam Sneddon Date: Thu, 2 Nov 2023 00:21:29 +0000 Subject: [PATCH 2/3] fixup! Fix #3009: unable to search for mixed case filenames --- webapp/components/test/test-search.html | 3 ++- webapp/package-lock.json | 24 ++++++++++++------------ webapp/package.json | 2 +- 3 files changed, 15 insertions(+), 14 deletions(-) diff --git a/webapp/components/test/test-search.html b/webapp/components/test/test-search.html index ad09b0d643..88be758d55 100644 --- a/webapp/components/test/test-search.html +++ b/webapp/components/test/test-search.html @@ -466,7 +466,8 @@ }); test('does not lowerCase', () => { - search_fixture.queryInput = "shadow-dom/DocumentOrShadowRoot-prototype-elementFromPoint.html"; + search_fixture.queryInput = 'a'; // first set is debounced + search_fixture.queryInput = 'shadow-dom/DocumentOrShadowRoot-prototype-elementFromPoint.html'; return waitingOn(() => search_fixture.structuredQuery) .then(() => { assert.equal(search_fixture.structuredQuery, { diff --git a/webapp/package-lock.json b/webapp/package-lock.json index 99dc2fffe2..15cbd6c370 100644 --- a/webapp/package-lock.json +++ b/webapp/package-lock.json @@ -7402,12 +7402,6 @@ "integrity": "sha512-EtKwoO6kxCL9WO5xipiHTZlSzBm7WLT627TqC/uVRd0HKmq8NXyebnNYxDoBi7wt8eTWrUrKXCOVaFq9x1kgag==", "dev": true }, - "node_modules/growl": { - "version": "1.10.0", - "resolved": "https://registry.npmjs.org/growl/-/growl-1.10.0.tgz", - "integrity": "sha512-ElsQbgadAZdhC8L+hx4RJu6fDe5uPCaRjdw8CvD39VYemGQT9CSiLdRAEYFWVIlCbPNlw+G4AbqBhQJF2qyHdg==", - "dev": true - }, "node_modules/gulp-if": { "version": "2.0.2", "resolved": "https://registry.npmjs.org/gulp-if/-/gulp-if-2.0.2.tgz", @@ -9546,6 +9540,12 @@ "node": "*" } }, + "node_modules/mocha/node_modules/growl": { + "version": "1.9.2", + "resolved": "https://registry.npmjs.org/growl/-/growl-1.9.2.tgz", + "integrity": "sha512-RTBwDHhNuOx4F0hqzItc/siXCasGfC4DeWcBamclWd+6jWtBaeB/SGbMkGf0eiQoW7ib8JpvOgnUsmgMHI3Mfw==", + "dev": true + }, "node_modules/mocha/node_modules/has-flag": { "version": "1.0.0", "resolved": "https://registry.npmjs.org/has-flag/-/has-flag-1.0.0.tgz", @@ -21358,11 +21358,6 @@ "integrity": "sha512-EtKwoO6kxCL9WO5xipiHTZlSzBm7WLT627TqC/uVRd0HKmq8NXyebnNYxDoBi7wt8eTWrUrKXCOVaFq9x1kgag==", "dev": true }, - "growl": { - "version": "https://registry.npmjs.org/growl/-/growl-1.10.0.tgz", - "integrity": "sha512-ElsQbgadAZdhC8L+hx4RJu6fDe5uPCaRjdw8CvD39VYemGQT9CSiLdRAEYFWVIlCbPNlw+G4AbqBhQJF2qyHdg==", - "dev": true - }, "gulp-if": { "version": "2.0.2", "resolved": "https://registry.npmjs.org/gulp-if/-/gulp-if-2.0.2.tgz", @@ -23060,7 +23055,7 @@ "diff": "3.5.0", "escape-string-regexp": "1.0.5", "glob": "7.1.1", - "growl": "1.9.2", + "growl": "1.10.0", "he": "1.1.1", "json3": "3.3.2", "lodash.create": "3.1.1", @@ -23096,6 +23091,11 @@ "path-is-absolute": "^1.0.0" } }, + "growl": { + "version": "https://registry.npmjs.org/growl/-/growl-1.9.2.tgz", + "integrity": "sha512-RTBwDHhNuOx4F0hqzItc/siXCasGfC4DeWcBamclWd+6jWtBaeB/SGbMkGf0eiQoW7ib8JpvOgnUsmgMHI3Mfw==", + "dev": true + }, "has-flag": { "version": "1.0.0", "resolved": "https://registry.npmjs.org/has-flag/-/has-flag-1.0.0.tgz", diff --git a/webapp/package.json b/webapp/package.json index 13cc750da5..f8e8820ac6 100644 --- a/webapp/package.json +++ b/webapp/package.json @@ -49,7 +49,7 @@ "multer@<1.4.5": "1.4.5-lts.1" }, "scripts": { - "test": "wct --local chrome && wct --local firefox", + "test": "wct --local chrome", "lint": "eslint 'components/*.js' && eslint --plugin html 'components/test/*.html'", "lint-fix": "eslint --fix 'components/**/*.js' && eslint --fix --plugin html 'components/test/*.html' ", "postinstall": "cpy 'node_modules/@browser-logos/{chrome,chrome-beta,chrome-canary,chrome-dev,chromium,deno,edge,edge-beta,edge-canary,edge-dev,firefox,firefox-beta,firefox-nightly,geckoview,node.js,safari,servo,uc}/*_64x64.png' static && cpy 'node_modules/@browser-logos/firefox-developer-edition/*_64x64.png' static --rename=firefox-dev_64x64.png && cpy 'node_modules/@browser-logos/safari/*_64x64.png' static --rename=safari-beta_64x64.png && cpy 'node_modules/@browser-logos/safari-technology-preview/*_64x64.png' static --rename=safari-dev_64x64.png && cpy 'node_modules/@browser-logos/safari-technology-preview/*_64x64.png' static --rename=safari-preview_64x64.png && cpy 'node_modules/@browser-logos/webkit-nightly/*_64x64.png' static --rename=wktr_64x64.png", From d4e3f6ba2fea985fe1d97246e703fba11a8cb3c5 Mon Sep 17 00:00:00 2001 From: Sam Sneddon Date: Thu, 2 Nov 2023 00:25:34 +0000 Subject: [PATCH 3/3] fixup! fixup! Fix #3009: unable to search for mixed case filenames --- webapp/components/test/test-search.html | 1 + 1 file changed, 1 insertion(+) diff --git a/webapp/components/test/test-search.html b/webapp/components/test/test-search.html index 88be758d55..54a41e86b1 100644 --- a/webapp/components/test/test-search.html +++ b/webapp/components/test/test-search.html @@ -466,6 +466,7 @@ }); test('does not lowerCase', () => { + search_fixture.structuredQueries = true; search_fixture.queryInput = 'a'; // first set is debounced search_fixture.queryInput = 'shadow-dom/DocumentOrShadowRoot-prototype-elementFromPoint.html'; return waitingOn(() => search_fixture.structuredQuery)