Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Avoid external CSS in the code. 404 error page. #642

Open
PeopleInside opened this issue Jan 22, 2023 · 0 comments
Open

Avoid external CSS in the code. 404 error page. #642

PeopleInside opened this issue Jan 22, 2023 · 0 comments
Labels
CSS Regarding Fixed Proposed Regarding PR is already added for this issue Ready for Next Release

Comments

@PeopleInside
Copy link
Contributor

PeopleInside commented Jan 22, 2023 •
edited
Loading

When not found 404 error page is showed, the CSS is not taken by the open source code but from https://cdn.uvdesk.com/uvdesk/css/main.css

community-skeleton/templates/errors/error.html.twig

Line 10 in 9416661

<link href="https://cdn.uvdesk.com/uvdesk/css/main.css" type="text/css" rel="stylesheet" media="all" />

Please include this CSS in the open source project and avoid load of external CSS also because cannot be maybe fixed by the user if some issue occurs also is better to have self-hosted as the other code.
@PeopleInside PeopleInside changed the title Take CSS of the 404 not found error from the opensource not cdn.uvdesk.com Avoid external CSS in the code. 404 error page. Jan 22, 2023
@Abhi12-gupta Abhi12-gupta mentioned this issue May 5, 2023
Closed
@komal-sh-27 komal-sh-27 added the Fixed Proposed Regarding PR is already added for this issue label May 23, 2023
papnoisanjeev added a commit that referenced this issue Nov 25, 2024
@papnoisanjeev
added main.css into project itself instead on cdn link #642
b722396
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
CSS Regarding Fixed Proposed Regarding PR is already added for this issue Ready for Next Release
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@PeopleInside @papnoisanjeev @komal-sh-27