Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UI should pop up a warning when merge fails due to offset too large #110

Open
cheneyuwu opened this issue Sep 9, 2021 · 0 comments
Open
Assignees
Labels
enhancement New feature or request

Comments

@cheneyuwu
Copy link
Collaborator

When user confirms a merge point by clicking on the yellow triangle, internally we check if the distance to the merging vertex is too large to merge. However, if a merge attempt is rejected due to offset too large, we silently drop back to branch state without popping up a warning saying merge attempt rejected in the UI, so the user wouldn't know why merge is not successful.

@cheneyuwu cheneyuwu added the enhancement New feature or request label Sep 9, 2021
@cheneyuwu cheneyuwu self-assigned this Sep 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant