Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

General UI improvements #8

Open
4 tasks
duembgen opened this issue Nov 28, 2024 · 0 comments
Open
4 tasks

General UI improvements #8

duembgen opened this issue Nov 28, 2024 · 0 comments

Comments

@duembgen
Copy link
Contributor

duembgen commented Nov 28, 2024 •
edited
Loading

Collection of notes by @holmesco and myself to improve the usability

  • get_Q should only return Q, not Q and y.
  • PolyMatrix.init_from_sparse() should return only matrix, not matrix and var_dict.
  • make only get_x an abstractmethod, because get_p shouldn't have to be defined when no parameters are required.
  • there is an assumption that there will always be landmarks. This should be removed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@duembgen