Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unify equality checks on (parse) trees. #2097

Open
PieterOlivier opened this issue Dec 9, 2024 · 0 comments
Open

Unify equality checks on (parse) trees. #2097

PieterOlivier opened this issue Dec 9, 2024 · 0 comments

Comments

@PieterOlivier
Copy link
Contributor

The interpreter has code to compare two (parse) trees in ConcreteSyntaxResult. This code works on IConstructor instances and assumes they are ITree instances
But ITree subclasses already have equals methods implemented that are much more efficient.

We should unify these implementations but keep in mind that we need to be able to compare with and without ignoring layout and keyword fields.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant