Search Page Integration

[panchi64]

Alrighty drop the convo here team 2.
@Jonathan-Rod @williammartinez10 @gustavosotero @RicardoJRSs @Yahid1 @yahirfigueroa y everyone else I can't remember rn

[Yahid1]

Can someone explain how the search bar component works?? Cause its giving the wrong results but maybe im using it wrong.

[Jonathan-Rod]

My latest commit:

• In summary, this MySearchBar component provides a basic search interface, where the user can enter search text and view the results in a list of cards.
• The actual search logic should be implemented in the part marked as // TODO within the handleSearch function.

[Yahid1]

Do you think you can fix what i described earlier based on this code?

[Jonathan-Rod]

Let me think about it.

[Yahid1]

This is another example

[Jonathan-Rod]

Let me propose:

1. Importing the List of Tutors:
   Importing the list of tutors within the component file instead of passing it as props can be a valid approach if the list is defined in another module.

2. Filtering Approach:
   Modifying the filtering approach to filter tutors whose names contain the search text (partial matching) is more appropriate if you want to find tutors whose names have any part of the search text, not just an exact match.

3. Removing searchText !== "":
   You can remove the condition searchText !== "" from the rendering logic if you want to simplify the code and rely on the fact that searchResults will only contain matching tutors when there's some search text.

[Jonathan-Rod]

I need to know all the requirements we need to perform a search.

Please comment below your expectations about:

1. Filtering
2. Rendering

[panchi64]

In an ideal world... I'd expect as a user to be able to search by department, class, and tutor.

However, If a user can just manage to search for a class and it can show me the tutors available for said class that works out just fine.

[panchi64]

I misread this completely 🙃

[Jonathan-Rod]

Well, a new feature as default options under the search bar as buttons that when clicked, set the list of results with a certain order, or from a certain department.

But focus on the actual content of the search bar, to find out what changes a stable version.

[Yahid1]

In the serv_page branch I finished an implementation of the search page. I connected all the components created using the data extrated from the listDepartments.js file that returns a List with all the data orginized.

Here is how the data looks like:

This is how it looks on the App in a browser:

I will also mention there is a new bug I found. When you filter, it keeps the wrong course expanded.

Here is an example video taken in the IOS app version showing the bug:

RPReplay_Final1695140924.mov

It is a bug because It’s not the course that I expanded originally.

To replicate the bug you have to:

1. Search INGE
2. Expand tutors on the Inge department
3. Then delete the search
   And you’ll find CIIC tutors expanded

Which shouldn’t happen cause I only expanded under INGE.

[Yahid1]

The correct behavior should be that it keeps the tutors from the INGE department expanded and only when they get filtered out should they get reset into not expanded.

[Yahid1]

I will create an Issue for this bug. For anyone to fix it.