Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The nebula.gl project has migrated to deck.gl-community/editable-layers #902

Open
ibgreen opened this issue Apr 23, 2024 · 6 comments
Open

Comments

@ibgreen
Copy link
Collaborator

ibgreen commented Apr 23, 2024

nebula.gl has been forked into the deck.gl-community repo.

@cfecherolle
Copy link

Hi! I was looking for a way to use https://www.npmjs.com/package/react-map-gl-draw with React 17 and react-map-gl but it's not compatible with React > 16, is this something that might be included in future work? Is react-map-gl-draw included in this fork?
Thank you!

@ibgreen
Copy link
Collaborator Author

ibgreen commented Apr 24, 2024

@cfecherolle As you can read in the table in the linked deck.gl-community documentation page, react-map-gl-draw was not included in the fork.

  • This decision was made to simplify the code base with the hope of making it easier for non-dedicated maintainers to keep the deck.gl layers version of nebula.gl alive.
  • Given that the new version is no longer broken into deck.gl independent modules, it may not be easy to add.

If it helps, react-map-gl-draw is a small module and you could probably bring the source code into your app and bump the react dependency.

@timnyborg
Copy link
Contributor

timnyborg commented May 2, 2024

@ibgreen do you have any intention of triaging the existing PRs on this repo, or should those of us with open fixes just port them across as new PRs on the deck.gl-community repo?

@ibgreen
Copy link
Collaborator Author

ibgreen commented May 2, 2024

do you have any intention of triaging the existing PRs on this rep

@timnyborg

  • I wish the core vis.gl team had the bandwidth to do that, but no. Simply getting the fork into a good shape has been heavy work for multiple contributors.
  • I also don't want to oversell the fork. While maintainers of other components have been willing to chip in and modernize build systems, dependencies etc, there is still no single thought leader or owner of the @deck.gl-community/editable-layers module, who can definitely answer whether a specific complex change is reasonable or not. This makes it harder to accept certain PRs etc.
  • So opening the same issues in the new repo is no guarantee of attention. However, the issues in this repo are almost certainly not going to be looked at.

@geraldo
Copy link

geraldo commented Sep 19, 2024

Thanks for your work! So what would be the recommended approach for a new project using editable-layers with latest deck.gl v9? I'm not sure if the advances described at visgl/deck.gl-community#38 mean that editable-layers is functional from the new deck.gl-community repo. Should I go with the staled nebula.js EditableGeojsonLayer module or got with the new forked one?

@ibgreen
Copy link
Collaborator Author

ibgreen commented Sep 20, 2024

So what would be the recommended approach for a new project using editable-layers with latest deck.gl v9? I'm not sure if the advances described at visgl/deck.gl-community#38 mean that editable-layers is functional from the new deck.gl-community repo. Should I go with the staled nebula.js EditableGeojsonLayer module or got with the new forked one?

What we can say is:

  • nebula.gl is for all intents and purposes dead. Contributors have been locked out from merging. I would not expect any further development, including a port to v9. We have asked if the repo could be archived by the owner, but no response.
  • editable-layers is an attempt to get the community to continue to maintain the key parts of nebula. It has been ported to deck.gl v9. It would be your best at this time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants