Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build fails in Vue with TS #866

Open
3 tasks
radoslavirha opened this issue Jan 24, 2023 · 0 comments
Open
3 tasks

build fails in Vue with TS #866

radoslavirha opened this issue Jan 24, 2023 · 0 comments

Comments

@radoslavirha
Copy link
Contributor

Describe the bug

Hi, I imported nebula to my Vue project, but now TS build is failing.

Actual Result

image

Expected Result

Build should pass

Reproduce Steps

just installed

"@nebula.gl/layers": "^1.0.4",
"@nebula.gl/overlays": "^1.0.4",

Investigation

@nebula.gl/layers imports @danmarshall/deckgl-typings which imports @types/react and those types are breaking my build

I cannot exclude it from build in tsconfig (nothing is working and I don't want to include all the types except of react types which I don't need in Vue at all).

Deck.gl is not happy with nebula types, but it can be solved with few @ts-ignore s

Maybe nebula can use deck.gl types (working fine)? Or are you waiting for v9 (which should have all the types included?)?

Temporary solution

remove @types/react in postinstall script

To Do List

  • Add label and assign to milestone
  • Coding
  • Test

Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant