Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ResizeCircleMode editType value should be distinguishable in onEdit callback #535

Open
3 tasks
KristerL opened this issue Mar 8, 2021 · 1 comment · May be fixed by #558
Open
3 tasks

ResizeCircleMode editType value should be distinguishable in onEdit callback #535

KristerL opened this issue Mar 8, 2021 · 1 comment · May be fixed by #558

Comments

@KristerL
Copy link

KristerL commented Mar 8, 2021

Describe the bug

Resize circle mode is missing distinguishable onEdit callback editType value. OnEdit callback gets editType props. This is really useful to toggle some kind of event after editing.

For example, when using Modify mode to drag a point in a polygon, then after dragging the final editType has a value 'finishMovePosition'.

Scale mode has editType "scaling" when dragging and "scaled" when dragging has finished.

Now the expectation is that resize circle has similar logic - while resizing editType is something that indicates that resizing is underway and after resize it is something like "resized", "finishedRezing, etc.

Actual Result

Currently resizeCircleMode returns only "unionGeometry"

Expected Result

When resize has finished it should say something to differentiate it from the resize in progress state.

Reproduce Steps

Editlayer where mode is resizeCircleMode and log the onEdit callback value.

Screenshot

edit

As a sidenote maybe the editType values should be consistent? Using multiple handlers developer has to take into account different wordings that basically indicate drag end.

Thank you for your work!

Version 0.22.3

To Do List

  • Add label and assign to milestone
  • Coding
  • Test
@KristerL
Copy link
Author

KristerL commented May 5, 2021

As a side note I also noticed that onHover callback on editableGeojsonLayer does not correctly work when resizing circles. Probably related to this problem

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant