You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Resize circle mode is missing distinguishable onEdit callback editType value. OnEdit callback gets editType props. This is really useful to toggle some kind of event after editing.
For example, when using Modify mode to drag a point in a polygon, then after dragging the final editType has a value 'finishMovePosition'.
Scale mode has editType "scaling" when dragging and "scaled" when dragging has finished.
Now the expectation is that resize circle has similar logic - while resizing editType is something that indicates that resizing is underway and after resize it is something like "resized", "finishedRezing, etc.
Actual Result
Currently resizeCircleMode returns only "unionGeometry"
Expected Result
When resize has finished it should say something to differentiate it from the resize in progress state.
Reproduce Steps
Editlayer where mode is resizeCircleMode and log the onEdit callback value.
Screenshot
As a sidenote maybe the editType values should be consistent? Using multiple handlers developer has to take into account different wordings that basically indicate drag end.
Thank you for your work!
Version 0.22.3
To Do List
Add label and assign to milestone
Coding
Test
The text was updated successfully, but these errors were encountered:
As a side note I also noticed that onHover callback on editableGeojsonLayer does not correctly work when resizing circles. Probably related to this problem
Describe the bug
Resize circle mode is missing distinguishable onEdit callback editType value. OnEdit callback gets editType props. This is really useful to toggle some kind of event after editing.
For example, when using Modify mode to drag a point in a polygon, then after dragging the final editType has a value 'finishMovePosition'.
Scale mode has editType "scaling" when dragging and "scaled" when dragging has finished.
Now the expectation is that resize circle has similar logic - while resizing editType is something that indicates that resizing is underway and after resize it is something like "resized", "finishedRezing, etc.
Actual Result
Currently resizeCircleMode returns only "unionGeometry"
Expected Result
When resize has finished it should say something to differentiate it from the resize in progress state.
Reproduce Steps
Editlayer where mode is resizeCircleMode and log the onEdit callback value.
Screenshot
As a sidenote maybe the editType values should be consistent? Using multiple handlers developer has to take into account different wordings that basically indicate drag end.
Thank you for your work!
Version 0.22.3
To Do List
The text was updated successfully, but these errors were encountered: