Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make modal link path-based rather than query-based #172

Open
bobheadxi opened this issue May 8, 2020 · 1 comment
Open

make modal link path-based rather than query-based #172

bobheadxi opened this issue May 8, 2020 · 1 comment
Labels
enhancement Website improvement

Comments

@bobheadxi
Copy link
Member

bobheadxi commented May 8, 2020

The initial implementation introduced in #94 uses query strings:

https://ubclaunchpad.com?project=physio+space#teams

Ideally this would be path-based, such that a link would look like:

https://ubclaunchpad.com/project/physio+space#teams

This change would mostly be for the sake of analytics, since paths are easier to sort through, and it just looks nicer. It also wouldn't cause too many issues because analytics indicate that hardly anybody uses the modal link feature at the moment, but we can maintain compatability with a redirect rule

@bobheadxi bobheadxi added the enhancement Website improvement label May 8, 2020
@bobheadxi bobheadxi mentioned this issue May 9, 2020
2 tasks
@bobheadxi
Copy link
Member Author

Update: on the analytics side I am using a hack to put the URL params into fathom trackPageview requests as if they were part of the normal path. Long-term I still think a path-based implementation would be a cleaner solution, however

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Website improvement
Projects
None yet
Development

No branches or pull requests

1 participant