-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
How to make it work for RTL? #8
Comments
Hi. I'll have a look for what we can do to add rtl support |
@tsdmrfth thanks for your consideration. |
Fixed in #14 |
@mehulgecg New version released now. Let me know if that works now |
This feature available now |
@tsdmrfth Great work with RTL but unfortunately it doesn't work as expected.
|
Hi @rajc-hkis. Which version of react-native-steve component are you using? |
@tsdmrfth I am on latest 0.4.1 |
This is from current version. Seems work correctly. What is the wrong about that? Screen.Recording.2021-04-14.at.16.41.42.mov |
@tsdmrfth Looks like it works for you which is good sign. I use forceRTL(true) in my app, you think that can cause issue? Since you use row-reverse when isRTL is set to true, I think that could be it. I attached video, so you can have better idea of the issue I am facing. :) Screen.Recording.2021-04-16.at.11.01.13.AM.mov |
Hi @rajc-hkis can you also provide some code about you issue? |
@tsdmrfth Code is same as provided in README file of this repo. |
I think that is the reason for the issue. forceRTL function call makes row reversed twice. RTL layout check should be done in component instead of expecting prop. |
@tsdmrfth Yes, agreed. You can check whether app is RTL or not by |
@rajc-hkis That makes sense 👊🏿 |
Really very good component, I've used this component in one of my apps but don't know how to make it work for RTL? any reference and help would be highly appreciated. Thank you so much.
The text was updated successfully, but these errors were encountered: