Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add support for 3D and assembly images #573

Closed
wants to merge 3 commits into from
Closed

add support for 3D and assembly images #573

wants to merge 3 commits into from

Conversation

techmannih
Copy link
Contributor

@techmannih techmannih commented Jan 15, 2025 •
edited
Loading

fix #568
/claim #568

@techmannih techmannih requested a review from seveibar as a code owner January 15, 2025 08:46
@tscircuitbot
Copy link

📊 Bundle Size Analysis

Total Bundle Size

  • Before: 30.69 MB
  • After: 30.69 MB
  • Change: 📉 0.00 B (0.00%)

Diff

No significant changes in bundle size.

View Dependencies
Package Size
typescript@^5.6.3 8.69 MB
@babel/standalone@^7.26.2 4.82 MB
ms@^2.1.3 531.75 KB
react@^18.3.1 528.29 KB
posthog-js@^1.203.2 229.68 KB
circuit-json@^0.0.130 194.84 KB
jszip@^3.10.1 139.73 KB
react-dom@^18.3.1 138.75 KB
zod@^3.23.8 117.16 KB
circuit-to-svg@^0.0.100 101.85 KB
tailwind-merge@^2.5.2 69.93 KB
@tscircuit/footprinter@^0.0.99 58.09 KB
dsn-converter@^0.0.54 32.96 KB
react-helmet@^6.1.0 29.13 KB
@radix-ui/react-scroll-area@^1.1.0 28.88 KB
@radix-ui/react-toast@^1.2.1 25.46 KB
fflate@^0.8.2 19.90 KB
@radix-ui/react-dialog@^1.1.1 11.97 KB
@radix-ui/react-popover@^1.1.1 10.63 KB
states-us@^1.1.1 7.27 KB
react-query@^3.39.3 5.93 KB
@radix-ui/react-tabs@^1.1.0 5.62 KB
@radix-ui/react-checkbox@^1.1.1 4.94 KB
use-mouse-matrix-transform@^1.3.0 4.73 KB
react-intersection-observer@^9.14.1 4.64 KB
zustand@^4.5.5 4.11 KB
lucide-react@^0.445.0 3.61 KB
file-saver@^2.0.5 3.58 KB
@vercel/analytics@^1.4.1 2.88 KB
@tscircuit/math-utils@^0.0.10 2.58 KB
redaxios@^0.5.1 1.83 KB
use-async-memo@^1.2.5 759.00 B
clsx@^2.1.1 723.00 B
vite@^5.4.8 644.00 B
codemirror@^6.0.1 595.00 B
country-list@^2.3.0 387.00 B
extract-codefence@^0.0.4 151.00 B
@tscircuit/core@^0.0.267 64.00 B
jscad-electronics@^0.0.24 63.00 B
What is this? This is an automated bundle size report generated during the build process.

@tscircuitbot
Copy link

📊 Bundle Size Analysis

Total Bundle Size

  • Before: 30.69 MB
  • After: 30.73 MB
  • Change: 📈 33.04 KB (0.11%)

Diff

Package Before After Diff Change
react@^18.3.1 528.29 KB 532.38 KB 📈 4.08 KB
0.77%
View Dependencies
Package Size
typescript@^5.6.3 8.69 MB
@babel/standalone@^7.26.2 4.82 MB
react@^18.3.1 532.38 KB
ms@^2.1.3 531.75 KB
posthog-js@^1.203.2 229.68 KB
circuit-json@^0.0.130 194.84 KB
jszip@^3.10.1 139.73 KB
react-dom@^18.3.1 138.75 KB
zod@^3.23.8 117.16 KB
circuit-to-svg@^0.0.100 101.85 KB
tailwind-merge@^2.5.2 69.93 KB
@tscircuit/footprinter@^0.0.99 58.09 KB
dsn-converter@^0.0.54 32.96 KB
react-helmet@^6.1.0 29.13 KB
@radix-ui/react-scroll-area@^1.1.0 28.88 KB
@radix-ui/react-toast@^1.2.1 25.46 KB
fflate@^0.8.2 19.90 KB
@radix-ui/react-dialog@^1.1.1 11.97 KB
@radix-ui/react-popover@^1.1.1 10.63 KB
states-us@^1.1.1 7.27 KB
react-query@^3.39.3 5.93 KB
@radix-ui/react-tabs@^1.1.0 5.62 KB
@radix-ui/react-checkbox@^1.1.1 4.94 KB
use-mouse-matrix-transform@^1.3.0 4.73 KB
react-intersection-observer@^9.14.1 4.64 KB
zustand@^4.5.5 4.11 KB
lucide-react@^0.445.0 3.61 KB
file-saver@^2.0.5 3.58 KB
@vercel/analytics@^1.4.1 2.88 KB
@tscircuit/math-utils@^0.0.10 2.58 KB
redaxios@^0.5.1 1.83 KB
use-async-memo@^1.2.5 759.00 B
clsx@^2.1.1 723.00 B
vite@^5.4.8 644.00 B
codemirror@^6.0.1 595.00 B
country-list@^2.3.0 387.00 B
extract-codefence@^0.0.4 151.00 B
@tscircuit/core@^0.0.267 64.00 B
jscad-electronics@^0.0.24 63.00 B
What is this? This is an automated bundle size report generated during the build process.

@algora-pbc algora-pbc bot mentioned this pull request Jan 15, 2025
Open
Abse2001
Abse2001 requested changes Jan 15, 2025
View reviewed changes
Copy link
Contributor

@Abse2001 Abse2001 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we need assembly and 3d SVGs not PCB

fake-snippets-api/routes/api/snippets/images/[author]/[snippet_name]/[typeFormat].ts
Comment on lines +61 to +68
} else if (type === "3d") {
svg = convertCircuitJsonToPcbSvg(
snippet.circuit_json as AnyCircuitElement[],
)
} else if (type === "assembly") {
svg = convertCircuitJsonToPcbSvg(
snippet.circuit_json as AnyCircuitElement[],
)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what is this man?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, my bad! I was thinking of something else.

@Abse2001
Copy link
Contributor

I think someone is working on convertCircuitJsonTo3dSvg bun I don't think it is ready yet.

@techmannih
Copy link
Contributor Author

got it , so we also need convertCircuitJsonToassemblysvg

@techmannih techmannih closed this Jan 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Abse2001 Abse2001 Abse2001 requested changes

@seveibar seveibar Awaiting requested review from seveibar seveibar is a code owner

Assignees
No one assigned
Labels
🙋 Bounty claim
Projects
None yet
Milestone
No milestone
3 participants
@techmannih @tscircuitbot @Abse2001