Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tpetra: Matrix-Matrix unit tests are disabled on SYCL #13199

Open
cwpearson opened this issue Jul 2, 2024 · 0 comments · May be fixed by #13198
Open

Tpetra: Matrix-Matrix unit tests are disabled on SYCL #13199

cwpearson opened this issue Jul 2, 2024 · 0 comments · May be fixed by #13198
Labels
pkg: Tpetra type: bug The primary issue is a bug in Trilinos code or tests

Comments

@cwpearson
Copy link
Contributor

kokkos/kokkos-kernels#1062 suggests the underlying issue was querying free memory, which has been resolved for a few years.

Trilinos/packages/tpetra/core/test/MatrixMatrix/FECrs_MatrixMatrix_UnitTests.cpp

Lines 396 to 399 in d2ba0c3

// FIXME_SYCL
#ifndef KOKKOS_ENABLE_SYCL
TPETRA_INSTANTIATE_SLGN_NO_ORDINAL_SCALAR( UNIT_TEST_GROUP_SC_LO_GO_NO )
#endif

Trilinos/packages/tpetra/core/test/MatrixMatrix/MatrixMatrix_UnitTests.cpp

Lines 2849 to 2859 in d2ba0c3

// FIXME_SYCL requires querying free device memory in KokkosKernels, see
// https://github.com/kokkos/kokkos-kernels/issues/1062.
// The SYCL specifications don't allow asking for that.
#ifdef HAVE_TPETRA_SYCL
#define UNIT_TEST_GROUP_SC_LO_GO_NO( SC, LO, GO, NT ) \
UNIT_TEST_GROUP_SC_LO_GO_NO_COMMON( SC, LO, GO, NT )
#else
#define UNIT_TEST_GROUP_SC_LO_GO_NO( SC, LO, GO, NT ) \
TEUCHOS_UNIT_TEST_TEMPLATE_4_INSTANT(Tpetra_MatMat, operations_test,SC, LO, GO, NT) \
UNIT_TEST_GROUP_SC_LO_GO_NO_COMMON( SC, LO, GO, NT )
#endif

@cwpearson cwpearson added the type: bug The primary issue is a bug in Trilinos code or tests label Jul 2, 2024
@cwpearson cwpearson linked a pull request Jul 2, 2024 that will close this issue
Open
@jhux2 jhux2 added this to Tpetra Aug 12, 2024
@jhux2 jhux2 moved this to Needs Triage in Tpetra Aug 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
pkg: Tpetra type: bug The primary issue is a bug in Trilinos code or tests
Projects
Tpetra
Status: Needs Triage
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Tpetra: enable SYCL matrix-matrix tests cwpearson/Trilinos
1 participant
@cwpearson