You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
On iOS I was doing some work to implement a shimmer loading view for a cell that contained 3 labels and an icon view. We have useful tokens to be able to keep the height of the labels accurate to their actual counterparts (in sass it'd be $tp-font__body__2__line-height), however the icons have no corresponding tokens.
@danoc pointed out that the SVGs don't actually depend on tokens since they have their height/width embedded, or hard-coded. It's possible that having 2 sources of truth might introduce issues.
The text was updated successfully, but these errors were encountered:
danoc
transferred this issue from thumbtack/thumbprint
Nov 1, 2019
On iOS I was doing some work to implement a shimmer loading view for a cell that contained 3 labels and an icon view. We have useful tokens to be able to keep the height of the labels accurate to their actual counterparts (in sass it'd be
$tp-font__body__2__line-height
), however the icons have no corresponding tokens.@danoc pointed out that the SVGs don't actually depend on tokens since they have their height/width embedded, or hard-coded. It's possible that having 2 sources of truth might introduce issues.
The text was updated successfully, but these errors were encountered: