Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tokens for the various different icon sizes #5

Open
bawjensen opened this issue Mar 11, 2019 · 0 comments
Open

Add tokens for the various different icon sizes #5

bawjensen opened this issue Mar 11, 2019 · 0 comments

Comments

@bawjensen
Copy link

On iOS I was doing some work to implement a shimmer loading view for a cell that contained 3 labels and an icon view. We have useful tokens to be able to keep the height of the labels accurate to their actual counterparts (in sass it'd be $tp-font__body__2__line-height), however the icons have no corresponding tokens.

@danoc pointed out that the SVGs don't actually depend on tokens since they have their height/width embedded, or hard-coded. It's possible that having 2 sources of truth might introduce issues.

@danoc danoc transferred this issue from thumbtack/thumbprint Nov 1, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant