Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update typography tokens to use new Title 1-8 and Text 1-3 #4

Open
danoc opened this issue Mar 20, 2019 · 3 comments
Open

Update typography tokens to use new Title 1-8 and Text 1-3 #4

danoc opened this issue Mar 20, 2019 · 3 comments

Comments

@danoc
Copy link
Member

danoc commented Mar 20, 2019

The type names were simplified a few months ago but the changes need to be reflected in tokens:

https://thumbprint.design/tokens/#section-type
@danoc
Copy link
Member Author

danoc commented Mar 21, 2019

This is actually kind of hard to do because we have deprecated tokens called tp-font__text*. I'm updating website and this codebase to remove the use of those before making a breaking version release of tokens.

danoc referenced this issue in thumbtack/thumbprint Mar 21, 2019
@danoc
Replace use of deprecated type tokens
841108c 
This is part of the work for #171.
danoc referenced this issue in thumbtack/thumbprint Mar 22, 2019
@danoc
Replace use of deprecated type tokens (#176)
d1143f2 
This is part of the work for #171.
@danoc
Copy link
Member Author

danoc commented Jun 7, 2019

The deprecated tokens previously mentioned no longer exist. This should be easier to do now.

@danoc danoc transferred this issue from thumbtack/thumbprint Nov 1, 2019
@danoc
Copy link
Member Author

danoc commented Dec 20, 2019

The remaining task here is to change body1, body2, body3 to text1, text2, text3.

@danoc danoc mentioned this issue Jan 10, 2020
Merged
@danoc danoc mentioned this issue Jan 22, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@danoc