Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update tokens to target es5 #3

Open
lavelle opened this issue Oct 25, 2019 · 0 comments
Open

Update tokens to target es5 #3

lavelle opened this issue Oct 25, 2019 · 0 comments
Assignees

Comments

@lavelle
Copy link
Contributor

lavelle commented Oct 25, 2019

Right now the ES Module build uses ES6 modules and ES6 syntax in the TypeScript config. We should target ES6 modules but ES5 syntax, to ensure no ES6 code can accidentally slip into IE11 when consumed by clients.

This is not a problem for the thumbprint-react package, since it uses Rollup and babel-plugin-typescript, rather than the tsc command directly.

cc @danoc

@lavelle lavelle self-assigned this Oct 25, 2019
@danoc danoc transferred this issue from thumbtack/thumbprint Nov 1, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant