Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify Tokens input in SCSS #2

Open
danoc opened this issue Jul 18, 2019 · 3 comments
Open

Simplify Tokens input in SCSS #2

danoc opened this issue Jul 18, 2019 · 3 comments

Comments

@danoc
Copy link
Member

danoc commented Jul 18, 2019

Instead of:

@import '@thumbtack/thumbprint-tokens/dist/scss/_index';

It'd be great if we could do:

@import '@thumbtack/thumbprint-tokens/scss';

Or, even better:

@import '@thumbtack/thumbprint-tokens';

That last one may not be possible yet. Maybe it will be once sass/node-sass#2339 merges.

@webbower
Copy link

I assumed @import '@thumbtack/thumbprint-tokens'; may not be doable since there's also the javascript-cjs and javascript-es folders and that the next segment would be necessary to differentiate.

@danoc
Copy link
Member Author

danoc commented Jul 19, 2019

I assumed @import '@thumbtack/thumbprint-tokens'; may not be doable since there's also the javascript-cjs and javascript-es folders and that the next segment would be necessary to differentiate.

I think it'll be possible once sass/node-sass#2339 merges the _index.scss file is in the root of the directory that we send to NPM. This is the folder we currently send: https://unpkg.com/@thumbtack/[email protected]/

@webbower
Copy link

webbower commented Jul 31, 2019

_index.scss is only relevant to SASS imports, not JS imports right? I was commenting on the JS imports.

@danoc danoc transferred this issue from thumbtack/thumbprint Nov 1, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants