Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Making Config a singleton #33

Open
0x6d6e opened this issue Mar 20, 2018 · 0 comments
Open

Making Config a singleton #33

0x6d6e opened this issue Mar 20, 2018 · 0 comments

Comments

@0x6d6e
Copy link

0x6d6e commented Mar 20, 2018 •
edited
Loading

Very handy tool. One observation though. Currently the Config class that is auto generated is initializable. So we can do something like let configInstance = Config(). Honestly though I am not sure whats wrong with that, but probably Config would be better off as a singleton or at least a private initializer. Cause we really dont want to instantiate Config
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@0x6d6e