make v5 backwards compatible with v4 data properties

[theBowja]

No description provided.

[tractorcow]

Hi @theBowja not sure if this is related, but it looks like the latest release of genshin-db-dist is generating properties in the v5 format (I noticed because I had elementType and elementText in characters, but no element field). This of course broke because the latest released version of genhin-db is 4.3.17.

Could genshin-db-dist have both a main (for v5) and v4 branch so that we can use both v4 and v5 concurrently?

I'd also like to install v5 of genshin-db but it doesn't seem released to npm yet.

Thanks again for your great work and let me know if I can help with anything.

[tractorcow]

Maybe an easier solution is to add some tags to genshin-db-dist, so we can lock to fixed database versions to protect from api changes?

[theBowja]

adding tags would surely be a good idea. if i could figure out how to do it o.o

[theBowja]

v5 db for 4.3 has already been published as 5.0.4

also i plan on dropping support for v4 db very soon

[tractorcow]

Nice one, upgrading to 5 now :D

[tractorcow]

adding tags would surely be a good idea. if i could figure out how to do it o.o

In the actions I see that you are getting the version from genshin-db.version, so I guess just trigger a git tag for that same value at the end of the execution?

[theBowja]

I just released genshin-db v5.0.7 which adds an option for backwards compatibility with genshin-db v4.

Simply add the following and all your property accesses should no longer throw errors.
genshindb.setOptions({ v4PropsOnly: true });

There are some rare pieces of data that couldn't be recovered so you should just do a quick checkover to see if anything is crashing on your end.

[tractorcow]

Upgrading to 5.x was painless, thank you for that! tractorcow/genshin-teamspin#6