Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[docs]: Questions #116

Open
Primajin opened this issue Sep 3, 2022 · 5 comments
Open

[docs]: Questions #116

Primajin opened this issue Sep 3, 2022 · 5 comments

Comments

@Primajin
Copy link

Primajin commented Sep 3, 2022

Hey there as mentioned in #115 here are some questions that came up during my first encounter with genshinDB.

First of all: THANK YOU for this great package ❤️, I am happy to support with PRs once I wrapped my head around a couple of things:

  1. How do I get all items of a similar type - like all slime items or all drops from childe - at best if I am already on a slime item, how do I know there are similar ones "left and right", meaning how can I easily check similar items
  2. I see there is genshinDB.weaponmaterialtypes and genshinDB.talentmaterialtypes
    1. Both of them link to examples in the README but apparently there are no examples.
    2. Why are there no / it would be great if there are genshinDB.levelmaterialtypes and genshinDB.ascensionmaterialtypes
  3. all the links to the categories.json from the README point to 404
  4. why is rarity a string and not an integer? It would be helpful if I could filter for rarity > X without the need to run parseInt first.
  5. How to get the max rarity per item? I would like to get a list of all materials but only the max possible one - for example slime can only go up to 3 while horn can go up to 4
  6. Why does genshindb.materials('ballad') only give me one Ballad item and not all items that match ballad?
@theBowja
Copy link
Owner

theBowja commented Sep 4, 2022

  1. Currently there's no easy way to get items of similar type. The closest for slime items is by searching enemies for slime. https://genshin-db-api.vercel.app/api/enemies?query=slime. Sounds like a good idea to add but I'm not sure on the best way to implement this.
  2. weaponmaterialtypes and talentmaterialtypes aren't updated. I've been meaning to remove them and implement it via some sort of pseudo folders.
  3. I was planning to create categories.json in my postprocessing step.
  4. rarity is a string because I accidentally made it a string early on and I decided to be consistent from then on. This can be changed to number probably. Not sure if it'll break anything for other people.
  5. hmm
  6. Unfortunately not possible yet. I'm currently considering a return x number of results option. I've been stalling because I couldn't figure out how to create the type for this. Maybe I should just create a separate function instead.

@Primajin
Copy link
Author

Primajin commented Sep 5, 2022

Alright, towards the weekend I'll try to come up with some ideas how we could address some of the points 🤞🏻

@Primajin
Copy link
Author

Primajin commented Sep 10, 2022

  1. We could maybe add an array of tags to every item, so that one can find similar items more easily
  2. Hmm OK - I would need an easy way to get items by categories:
    • Talent Level-Up Material (Books) --> "Ballad"
    • Talent Level-Up Material (Weekly Boss) --> "Dvalin's Plume"
    • Weapon Ascension Material --> "Aerosiderite"
    • Character Ascension material (Gems) --> "Agnidus Agate Gemstone"
    • Character Ascension material (Normal Boss Drops) --> "Hurricane Seed"
    • Common Ascension Material --> General Enemy / Elite Enemy --> "Slime"
  3. 👍🏻
  4. With dynamic typing it also works okayish right now, it's just a bit dirty to do '3' + 1
  5. This might be solved if we can distinguish between general enemy drops and elite enemy drops, general are always 1,2,3 - elite are always 2,3,4. We could add another property like elite: true or so?

BTW - since you said you are interested for what it's used:
I am building a farming helper:
https://primajin.github.io/genshin-farming-helper/
https://github.com/Primajin/genshin-farming-helper

This allows you to choose the items you want to track and every time you kill a monster or finish a domain you can quickly tap how many of which item you got. It will automatically count up 3 of each to the next level (unless you tick the lock).
farm-help

@theBowja
Copy link
Owner

im gonna add data for crafting

@Primajin
Copy link
Author

Alright great, for now I added a temporary static list https://github.com/Primajin/genshin-farming-helper/blob/main/src/constants/index.js#L21

Also added some fancy design - so the app can be tested in Beta 😍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants