-
-
Notifications
You must be signed in to change notification settings - Fork 61
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Documentation for GitLab integration? #398
Comments
I would accept a PR to add example to readme.
cc @mike-kfed Any thoughts on this? |
I know about those limitations. My project also has a tool to split up the big xml files into 9.5MiB chunked files. This tool is not part of cargo-llvm-cov. Not sure you @taiki-e want to have that functionality in your tool? If you like I can make a PR to add that feature though, with an additional cmd line argument. It could automagically number the output xml filename based on the initial one. Then the output would be the big xml and the chunked one's, then gitlab-ci script could only upload the numbered one's. (this implies that a small xml would also be "split" into one xml with the postfix tldr; if you want that feature, we should likely discuss that in a separate issue - right now the gitlab-ci could use my tool as part of it's script to split the large xml, i.e. be part of the proposed documentation. |
To be honest, I was not planning on doing the splitting - I'm certainly not generating reports large enough for that to be an issue. I'm hesitant to document things I can not test myself. For now, I will do the basic setup, without splitting, and someone can go on from there. Another issue is the image used. When it comes to GitLab CI, running Perhaps just a snippet, showing how to run |
I like your plan, it's sufficient to document it without the splitting. To generate >10MiB worth of cobertura xml, your codebase has to be huge. Whoever runs into this situation can add update the documentation on how to deal with this later. However these are just my 2 cents, Taiki is the maintainer of this project, ultimately his opinion counts. |
I will probably be working on integrating
cargo-llvm-cov
later this week (since it seems all the pieces are in place), would you be open to a PR documenting that? If so, is the README the right place? From my initial look, this should be straightforward and even shorter than GitHub Actions upload to Codecov.While I'm at it, here are the limitations mentioned in GitLab docs, do you foresee any issues?
The text was updated successfully, but these errors were encountered: