Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement logout #34

Open
benkeil opened this issue Aug 11, 2021 · 3 comments
Open

Implement logout #34

benkeil opened this issue Aug 11, 2021 · 3 comments

Comments

@benkeil
Copy link

benkeil commented Aug 11, 2021

As far as I see, there is no logout implemented. Or did I missed something?

https://docs.microsoft.com/en-us/azure/active-directory/develop/scenario-web-app-sign-user-sign-in?tabs=aspnetcore#sign-out

@swelham
Copy link
Owner

swelham commented Aug 17, 2021

Hi, thanks for raising this.

My understanding is ueberauth only focuses on authenticating requests and doesn't look to implement anything in addition to that. This doesn't necessarily mean this library couldn't support additional authentication features, though to break consistency with other ueberauth adapters I feel it would need to be clear why it is necessary.

I have had a quick look at some of the official ueberauth adapters (google, facebook, github) and those don't appear to support logout. Are you aware of any other adapters that support this feature?

@benkeil
Copy link
Author

benkeil commented Aug 17, 2021

I‘m not deep enough in the topic to be honest.

I also don’t know what a User really wants.
min the other hand, I expect the effort is not very high and it is not bad to have this feature?

@swelham
Copy link
Owner

swelham commented Aug 20, 2021

Thanks for the feedback.

I think it would be great to look into this feature and I'm definitely open to a PR if anyone reading this is interested.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants