Skip to content
This repository has been archived by the owner on May 4, 2021. It is now read-only.

Nicer emails #3

Open
fellhorn opened this issue Jun 2, 2017 · 14 comments
Open

Nicer emails #3

fellhorn opened this issue Jun 2, 2017 · 14 comments

Comments

@fellhorn
Copy link
Collaborator

fellhorn commented Jun 2, 2017

HTML mails and also confirmation of user input data

@fellhorn
Copy link
Collaborator Author

fellhorn commented Jun 4, 2017

We should also add some basic information about the event:
Date & time when it starts, timeslots of the dishes, ...

@marcelklehr
Copy link
Member

Where in the code base is the code that sends mails?

@marcelklehr
Copy link
Member

Nevermind. grep ftw! ;)

@marcelklehr
Copy link
Member

Is there a reason the confirmation email is not sent to both participants of a house in one go?

@danielrenninghoff
Copy link
Contributor

No :D. You can change that. But what I will do is send the sepa lastschriftmandat only to email1 (in a separate mail).

@danielrenninghoff
Copy link
Contributor

Actually, we use the name of the person in the email-text, so it needs to be separate.

@marcelklehr
Copy link
Member

Great. We could write "Hello {name1} and {name2}", though.

@danielrenninghoff
Copy link
Contributor

Ok, that sounds like a good idea :)! btw, I just commited a change to the email_senden function.

@marcelklehr
Copy link
Member

In a68cd76...master I introduced mail templates. I haven't tested actually sending the mail as I don't have a mail server, though.

@marcelklehr
Copy link
Member

marcelklehr commented Jun 4, 2017

Also, The about-us section would benefit from being placed into a separate, reusable template, so both mails and frontend can use it...

@danielrenninghoff
Copy link
Contributor

The problem with html emails is that you can't be sure how they will get rendered and that is a big problem. A lot of email clients don't load external sources by default and then your emails will look really bad. Another problem is HTML5 support. The current templates you developed use bootstrap and HTML5. Most email clients don't even render divs correctly and that is why email templates often still use tables and inline styles.

For more information:
https://stackoverflow.com/questions/127498/what-guidelines-for-html-email-design-are-there
https://stackoverflow.com/questions/4829254/best-practices-for-styling-html-emails
http://foundation.zurb.com/emails.html

The last link shows an alternative to bootstrap that is specifically optimized for emails.

So in total, crafting email templates is a complicated process that imho is not worth it for our use case. It is especially not feasible to share code between the main site and the html template.

I'm of the opinion that we should remove the html mails in their current form, because having a simple plaintext email that everybody can read is better than having a html email that looks like **** because the client is rendering it wrong.

On the other hand I think your plaintext templates are really nice and we should continue using them.

Any opinions about this topic?

@marcelklehr
Copy link
Member

Fuu, didn't know about that... That sucks. Then I agree that we should avoid HTML mails.

@fellhorn
Copy link
Collaborator Author

fellhorn commented Jun 4, 2017

Yeah I know about this issue. I used the zurb templates for a customer once. They provide something like a very basic common understanding for almost all mail clients. I personally like the welcome template from this site:
http://foundation.zurb.com/emails/email-templates.html

We should definitely spend not more effort than using a copy & paste template. In my opinion it would be already enough using only some table layouting and putting the logo in the mail. Just to make it a bit nicer. (Says the guy reading mails only in plaintext...)

@marcelklehr
Copy link
Member

marcelklehr commented Jun 4, 2017 via email

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants