Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

addon-google-analytics: not compatible with Storybook 7 beta #20366

Open
jagomf opened this issue Dec 21, 2022 · 1 comment · May be fixed by storybookjs/addon-google-analytics#6
Open

addon-google-analytics: not compatible with Storybook 7 beta #20366

jagomf opened this issue Dec 21, 2022 · 1 comment · May be fixed by storybookjs/addon-google-analytics#6
Labels
api: addons help wanted

Comments

@jagomf
Copy link

jagomf commented Dec 21, 2022 •
edited
Loading

Describe the bug

I upgraded to Storybook 7 beta 12 using the automatic method (npx storybook@next upgrade --prerelease) + automigrations. This gave me the following package.json dependencies (amongst others):

"storybook": "^7.0.0-beta.12",
"@storybook/angular": "^7.0.0-beta.12",
"@storybook/addons": "^7.0.0-beta.12",
"@storybook/addon-google-analytics": "^6.3.0-next.1",

I then reset my workspace (I guess I probably deleted package-lock.json) and tried to do npm i again.
This is what I get:

npm ERR! code ERESOLVE
npm ERR! ERESOLVE unable to resolve dependency tree
npm ERR! 
npm ERR! While resolving: my-project
npm ERR! Found: @storybook/[email protected]
npm ERR! node_modules/@storybook/addons
npm ERR!   dev @storybook/addons@"^7.0.0-beta.12" from the root project
npm ERR! 
npm ERR! Could not resolve dependency:
npm ERR! peer @storybook/addons@"^6.1.14" from @storybook/[email protected]
npm ERR! node_modules/@storybook/addon-google-analytics
npm ERR!   dev @storybook/addon-google-analytics@"^6.3.0-next.1" from the root project
npm ERR! 
npm ERR! Fix the upstream dependency conflict, or retry
npm ERR! this command with --force, or --legacy-peer-deps
npm ERR! to accept an incorrect (and potentially broken) dependency resolution.

So I understand that addon-google-analytics does not yet support Storybook 7 beta.

System

System:
    OS: macOS 12.6
    CPU: (8) x64 Apple M1
  Binaries:
    Node: 16.19.0 - ~/.nvm/versions/node/v16.19.0/bin/node
    npm: 8.19.3 - ~/.nvm/versions/node/v16.19.0/bin/npm
  Browsers:
    Chrome: 108.0.5359.124
  npmPackages:
    @storybook/storybook-deployer: ^2.8.6 => 2.8.12
@shilman shilman moved this to Required for RC in Core Team Projects Dec 21, 2022
@shilman shilman moved this from Required for RC to Required for GA in Core Team Projects Jan 23, 2023
@jonniebigodes
Copy link
Contributor

jonniebigodes commented Jan 31, 2023 •
edited
Loading

Hey @jagomf 👋 !
Thanks for reaching out to us regarding your issues with the addon and the Storybook beta. As you may or may not know, the API for building addons changed a bit with 7.0, impacting this addon. With this, I was wondering if you'd be interested in collaborating with us by contributing with a pull request to factor in the changes for it to support the upcoming 7.0 release. To help you get started, we've prepared an abridged guide for the required changes here, and if you have any questions or issues, please reach out to us in the #prerelease channel in our Discord Server.

To help keep track of the changes, I've raised an issue in the addon's repo here, feel free to respond there.

Looking forward to hearing from you.

Hope you have a fantastic day.

Stay safe

@jonniebigodes jonniebigodes mentioned this issue Jan 31, 2023
Open
32 tasks
@shilman shilman linked a pull request Mar 21, 2023 that will close this issue
Open
@shilman shilman assigned ndelangen and unassigned jonniebigodes Mar 21, 2023
@shilman shilman moved this from Required for GA to Nice to have in Core Team Projects Mar 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
api: addons help wanted
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Update Addon for Storybook v7.0 fgaleano/addon-google-analytics
3 participants
@ndelangen @jagomf @jonniebigodes