Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

StoryblokRichTextNode type not 100% correct #151

Open
FabianKoder opened this issue Nov 22, 2024 · 0 comments
Open

StoryblokRichTextNode type not 100% correct #151

FabianKoder opened this issue Nov 22, 2024 · 0 comments
Assignees
Labels
bug Something isn't working good first issue [Contribution] Good for newcomers p2-edge-case [Priority] Bugs with workarounds or limited impact. PR welcome [Contribution] Pull requests are welcome.

Comments

@FabianKoder
Copy link

FabianKoder commented Nov 22, 2024


Expected Behavior

If I investigated it correctly, the type should require content to be defined at the first level, but all sub-nodes don't need content to be present.

Current Behavior

The API can return undefined as content in sub-nodes of StoryblokRichTextNode, but the types right now say that in every level of the RichText structure content is present.

We use a custom type which raises the following error because sub-nodes always need content present, which is not the case at the API level.

image

Steps to Reproduce

N/A

@alvarosabu alvarosabu added bug Something isn't working p2-nice-to-have [Priority] Lower priority, beneficial enhancements that are not urgent. labels Dec 9, 2024
@alvarosabu alvarosabu self-assigned this Dec 9, 2024
@alvarosabu alvarosabu added good first issue [Contribution] Good for newcomers p2-edge-case [Priority] Bugs with workarounds or limited impact. PR welcome [Contribution] Pull requests are welcome. and removed p2-nice-to-have [Priority] Lower priority, beneficial enhancements that are not urgent. labels Dec 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working good first issue [Contribution] Good for newcomers p2-edge-case [Priority] Bugs with workarounds or limited impact. PR welcome [Contribution] Pull requests are welcome.
Projects
None yet
Development

No branches or pull requests

2 participants