Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tests for training on subset of data #28

Open
pcarbo opened this issue Aug 23, 2024 · 3 comments
Open

Tests for training on subset of data #28

pcarbo opened this issue Aug 23, 2024 · 3 comments

Comments

@pcarbo
Copy link
Member

pcarbo commented Aug 23, 2024

@eweine Can you please add a testthat test (or tests) checking for correctness with training_frac < 1?

@eweine
Copy link
Collaborator

eweine commented Aug 23, 2024

Yes!

I believe that the only straightforward way to do this is to fix U and compare fitting V with training_frac = 1 and training_frac < 1. The results should be the same. I will try this.

@eweine
Copy link
Collaborator

eweine commented Aug 23, 2024

Hmm I am now realizing that this isn't straightforward with the current way that we have written the code. There is no option to fix U or V, and while you can provide covariates (i.e. X and Z), I don't think you can fit a model with K = 0 and just values of X and Z. @pcarbo should we somehow allow the user to do this? Or, should we figure out another way to test this?

@pcarbo
Copy link
Member Author

pcarbo commented Aug 26, 2024

If you run with, say, training_frac = 0.99 and training_frac = 1, the results should be very similar on a simple simulated data set (and if you initialize in the same way)?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants