Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove CreateAccountSigner function and update the unit tests #5109

Open
urvisavla opened this issue Nov 11, 2023 · 0 comments
Open

Remove CreateAccountSigner function and update the unit tests #5109

urvisavla opened this issue Nov 11, 2023 · 0 comments
Labels
horizon ingest New ingestion system

Comments

@urvisavla
Copy link
Contributor

What problem does your feature solve?

After the change in #5105 to use FastBatchInsertBuilder in SignersProcessor, the CreateAccountSigner function is no longer used anywhere except for unit tests. This function should be removed.

What would you like to see?

Update the unit tests that are currently using CreateAccountSigner to use AccountSignersBatchInsertBuilder and then delete the function.

What alternatives are there?

N/A
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
horizon ingest New ingestion system
Projects
Platform Scrum
Status: To Do
Milestone
No milestone
Development

No branches or pull requests
2 participants
@mollykarcher @urvisavla