You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Expected Behavior
When client assertions fail validation, the exception message contains the parameter name.
Current Behavior
When client assertions fail validation the exception message is empty.
Context
Since the validation is for internal use and does not expose what parameter has failed validation, it is required to wrap the existing converter and re-run the validation adding the failed parameter name. Adding this will save time when troubleshooting what the client is sending incorrectly without adding additional logging since the exception is already thrown.
The text was updated successfully, but these errors were encountered:
@felix-hellman Thanks for the PR associated to this issue. However, the changes in the PR would make the OAuth2Error inconsistent with the other client authentication converters ClientSecretBasicAuthenticationConverter, ClientSecretPostAuthenticationConverter and PublicClientAuthenticationConverter.
Furthermore, I'm not sure enhancing the error message to include the parameter name is the long term solution we're looking. I think we'll need to address this in gh-1240 and implement a holistic solution.
I'm going to close this issue and associated PR but feel free to add any additional comments to gh-1240.
Expected Behavior
When client assertions fail validation, the exception message contains the parameter name.
Current Behavior
When client assertions fail validation the exception message is empty.
Context
Since the validation is for internal use and does not expose what parameter has failed validation, it is required to wrap the existing converter and re-run the validation adding the failed parameter name. Adding this will save time when troubleshooting what the client is sending incorrectly without adding additional logging since the exception is already thrown.
The text was updated successfully, but these errors were encountered: