You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
staticconstexprconstchar *EXTERNAL_PLUGIN_PROCESS_DOCSTRING = R"(Pass a buffer of audio (as a 32- or 64-bit NumPy array) *or* a list ofMIDI messages to this plugin, returning audio.(If calling this multiple times with multiple effect plugins, considercreating a :class:`pedalboard.Pedalboard` object instead.)When provided audio as input, the returned array may contain up to (but notmore than) the same number of samples as were provided. If fewer sampleswere returned than expected, the plugin has likely buffered audio insideitself. To receive the remaining audio, pass another audio buffer into ``process`` with ``reset`` set to ``True``.
If my understanding of how reset works, should the last sentence be rewritten to To receive the remaining audio, pass another audio buffer into process with reset set to False. ? (since setting reset to True will precisely remove the bufferized audio)
If I am not mistaken, I can do a little PR and maybe look if some other bits of doc mention it.
TIA for your opinion.
The text was updated successfully, but these errors were encountered:
Hello
I am reading this in the docs:
If my understanding of how
reset
works, should the last sentence be rewritten to To receive the remaining audio, pass another audio buffer intoprocess
withreset
set toFalse
. ? (since settingreset
toTrue
will precisely remove the bufferized audio)If I am not mistaken, I can do a little PR and maybe look if some other bits of doc mention it.
TIA for your opinion.
The text was updated successfully, but these errors were encountered: