Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SpinApp: Support tolerations config #218

Open
vdice opened this issue Apr 24, 2024 · 2 comments
Open

SpinApp: Support tolerations config #218

vdice opened this issue Apr 24, 2024 · 2 comments
Labels
enhancement New feature or request needs discussion

Comments

@vdice
Copy link
Contributor

vdice commented Apr 24, 2024

Feature request to support sending in user-defined node toleration config to the pod(s) representing a given SpinApp.
@endocrimes
Copy link
Contributor

endocrimes commented Apr 24, 2024 •
edited
Loading

I think these would be a good fit for executor config - tolerations are things you usually want to apply to a class of software rather than one-off apps (although I'm not really sure where SpinKube would be a good fit for many of those cases - I'd love to collect some before we move ahead with design work)

@endocrimes endocrimes added enhancement New feature or request needs discussion labels Apr 24, 2024
@vdice
Copy link
Contributor Author

vdice commented Apr 24, 2024 •
edited
Loading

Via executor config could work. Use case would be to isolate all SpinApps for a given executor to a subset of nodes. I don't currently envision needing finer-grained toleration/scheduling control than that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request needs discussion
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@endocrimes @vdice