We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
In the option.dart file a comment suggests that the code below the comment has side effects.
option.dart
// PURISTS BEWARE: side effecty stuff below -- proceed with caution!
One Method there is the toNullable() method.
toNullable()
It looks like that:
A? toNullable() => fold(() => null, id);
This method does not seem to create a side effect and therefore it should be above the stated comment to avoid confusion.
I would create a PR that moves the method upwords, so that it is above the comment. Would this PR be merged?
The text was updated successfully, but these errors were encountered:
No branches or pull requests
In the
option.dart
file a comment suggests that the code below the comment has side effects.// PURISTS BEWARE: side effecty stuff below -- proceed with caution!
One Method there is the
toNullable()
method.It looks like that:
This method does not seem to create a side effect and therefore it should be above the stated comment to avoid confusion.
I would create a PR that moves the method upwords, so that it is above the comment. Would this PR be merged?
The text was updated successfully, but these errors were encountered: