Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add composition to validity metric #56

Closed
sgbaird opened this issue Aug 7, 2022 · 0 comments · Fixed by #57
Closed

Add composition to validity metric #56

sgbaird opened this issue Aug 7, 2022 · 0 comments · Fixed by #57

Comments

@sgbaird
Copy link
Member

sgbaird commented Aug 7, 2022

E.g. distance calculation based on fingerprint + threshold

Could be a scalar featurizer (seems most straightforward, use EMD between distributions, normalize by some dummy metric, and average the two distributional distances).

Could be smact_validity, but probably need a way to do a logical AND match (i.e. change structure validity to be a YES/NO on a per-structure basis - also, it's no longer comparing to train+test at that point, it's standalone).

#44

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant