Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Python 3.12 support #210

Closed
xlxs4 opened this issue Feb 6, 2024 · 17 comments · Fixed by #270
Closed

Python 3.12 support #210

xlxs4 opened this issue Feb 6, 2024 · 17 comments · Fixed by #270
Labels
enhancement New feature or request

Comments

@xlxs4
Copy link

xlxs4 commented Feb 6, 2024

Have you looked into this? Besides distutils (removed in Python 3.12) used by digikey-api (peeter123/digikey-api#48), is there any other dependency holding >3.11 support back?

@eeintech eeintech added the question Further information is requested label Feb 9, 2024
@eeintech
Copy link
Contributor

eeintech commented Feb 9, 2024

I haven't looked into it yet and I haven't used Python 3.12 yet but I'm aware it has been out for a while now, I will check on the next release what's missing to get there, thanks!

@AndronikosKostas
Copy link

any news on this?

@eeintech
Copy link
Contributor

@AndronikosKostas No news, the digikey API package hasn't been updated yet and I haven't had the chance to test Python 3.12 yet.

@chl33
Copy link

chl33 commented Aug 15, 2024

This would be useful to me, as I just updated to Ubuntu 24.04 which uses Python 3.12.

@eeintech
Copy link
Contributor

It's next on my TODO list 😄 There is a PR (peeter123/digikey-api#51) already in place, I need to test it out. It also involves the new Digi-Key API so it will take a bit more testing to verify everything is good. The digikey-api does not seem to be maintained anymore so maybe a fork would be needed soon...

@T0jan
Copy link
Collaborator

T0jan commented Oct 15, 2024

As this gets now important for me as well as our IT wants to switch to 24.04 as well I would vote for replacing the digikey package with the fork. The maintainer hasn't done anything there in years so it's save to say he wont come back to enable 3.12 compatibility soon. There are some workarounds to get 3.11 working on newer distros but it's not convenient.

@T0jan
Copy link
Collaborator

T0jan commented Oct 15, 2024

Also this will probably be a ubuntu 24.04 specific problem which needs to be solved: actions/runner-images#10781

@eeintech
Copy link
Contributor

Hello @T0jan I may not have a lot of time on hands in the next few weeks, I did want to get it up and running on 3.12 at one point though... WSL 24.04 seems to be available for Windows now, that was also missing for my setup. I will start by checking that one out.

@T0jan
Copy link
Collaborator

T0jan commented Oct 15, 2024

@eeintech if you need some help on the Linux side, I have some time to spare rn. Just tell me what you would need.

@eeintech
Copy link
Contributor

eeintech commented Oct 15, 2024

I was able to run Ki-nTree with Python3.12 and both:

So not with a single fork... and I haven't tried the Digi-Key API v4, did you?

@T0jan
Copy link
Collaborator

T0jan commented Oct 15, 2024

@eeintech doesn't the first fork automatically use the v4 API? Or do you mean just checking if it works?

Also, I figured out how to get Flet and therefore Ki-nTree running on rolling release distros, if you want I can add a section on it to the README.

@eeintech
Copy link
Contributor

@T0jan The new Digi-Key API response is slightly different, so Ki-nTree would need to adapt to it. I had created an instance on Digi-Key's developer website to test it out but haven't had the chance to update the parsing yet.

Also, I figured out how to get Flet and therefore Ki-nTree running on rolling release distros, if you want I can add a section on it to the README.

That'd be great!

@T0jan
Copy link
Collaborator

T0jan commented Oct 16, 2024

@eeintech I will see what adaptations are needed for DigiKey v4 and fix the other minor bugs still open as well in the next days

@eeintech
Copy link
Contributor

@T0jan Awesome thanks 👍

@eeintech eeintech added enhancement New feature or request and removed question Further information is requested labels Oct 16, 2024
@eeintech
Copy link
Contributor

eeintech commented Oct 16, 2024

Btw, there was a pending PR which I finally merged. Now that 1.1.4 is out, I think we should be aiming for 1.2.0 to enable Python 3.12 and Digi-Key v4 compatibility (+extra features/bug fixes).

@eeintech eeintech mentioned this issue Dec 29, 2024
@chl33
Copy link

chl33 commented Dec 29, 2024

Thanks for the update and fix! I got things working again on my Ubuntu 24.04 system.

To do this, I needed to do a couple tweaks after installing the wheel from the .zip file.

To fix an error about a missing shared library libmvp.so.1, I did:

sudo apt install libmpv-dev libmpv2
sudo ln -s /usr/lib/x86_64-linux-gnu/libmpv.so /usr/lib/libmpv.so.1

There is no libmvp1 package available. This is maybe questionable, but it got the app to start at any rate.

I then got an error about an missing user setting OPN_USE_MANUFACTURER_PART_NUMBER . So in my existing ~/.config/kintree/user/internal_part_number.yaml I added

IPN_USE_MANUFACTURER_PART_NUMBER: true

and now the app runs.

@eeintech
Copy link
Contributor

eeintech commented Jan 2, 2025

Hello @chl33 Thanks for the report and steps to get 1.2.0 running.

I'm surprised you encountered an issue with a parameter, Ki-nTree tries to creates the missing on startup, maybe this one is not taken into account... I will open an issue to make sure it is in the future versions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants