Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update alignment parameters for pipeline and SVM processing #1925

Open
mackjenn opened this issue Jan 3, 2025 · 1 comment · May be fixed by #1932
Open

Update alignment parameters for pipeline and SVM processing #1925

mackjenn opened this issue Jan 3, 2025 · 1 comment · May be fixed by #1932

Comments

@mackjenn
Copy link

mackjenn commented Jan 3, 2025

A fix for the alignment logic is requested for the next drizzlepac build. These changes are important to avoid skewing the images by allowing for complex fit geometry when there only a few catalog matches.

At the moment we have the following parameters for all instruments/detectors. The code will attempt “rshift”, “rscale”, and “general” fit geometry with the number of required NMATCHES for pipeline products (mosaic_rel_geom) and SVM products (mosaic_fitgeom).

"mosaic_relgeom_list": {"rshift":20, "rscale": 10, "general": 9}
"mosaic_fitgeom_list": {"rshift": 4, "rscale": 10, "general": 6},

This is not the desired logic which should apply a more complex fit geometry only with a large number of matches. WFC3 and ACS have been digging into to accuracy our current distortion solutions and based on those results, we would like to change the parameters to the following:

"mosaic_relgeom_list": {"rscale": 12}
"mosaic_fitgeom_list": {"rscale": 12, "general": 25}

We find errors in the filter-dependent scale in the geometric distortion reference file, so we want to eliminate the 'rshift' option and allow the software to fit for scale terms when aligning images. We increase the number of required matches from 10 to 12 to account for sigma-clipping. To fit for skew errors in the distortion (e.g. general fit), we find that a large number of sources are required for a good fit.

As Michele suggests in https://jira.stsci.edu/browse/HLA-1385, we need to discuss as a group and then ask Matt to run a large regression test so that the impact of this update can be assessed in an isolated manner.

@stscijgbot-hstdp
Copy link
Collaborator

This issue is tracked on JIRA as HLA-1405.

@s-goldman s-goldman linked a pull request Jan 16, 2025 that will close this issue
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants