Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No blame info on files with spaces #44

Open
sqs opened this issue Apr 25, 2019 · 1 comment
Open

No blame info on files with spaces #44

sqs opened this issue Apr 25, 2019 · 1 comment
Assignees
Labels
good first issue Good for newcomers

Comments

@sqs
Copy link
Member

sqs commented Apr 25, 2019

https://sourcegraph.sgdev.org/github.com/sourcegraph/Graphbook/-/blob/Dev%20lingo%20for%20non-devs.md?view=code#L15

No blame info is shown at the end of the line, even with blame enabled. Possibly a bug when viewing the raw (non-Markdown-rendered) file?

image

@felixfbecker
Copy link
Contributor

Issues here:

  • URI is not decoded. Error from backend is git ls-tree Dev%20lingo%20for%20non-devs.md: file does not exist
  • String concatenation with an object, resulting in [object Object] being logged.

This is a good example btw of how dangerous it is that a core feature like blame has seen no code review and has no tests - these two issues that could have easily been caught through review.

@felixfbecker felixfbecker changed the title No blame info on raw Markdown file No blame info on files with spaces Apr 26, 2019
@felixfbecker felixfbecker transferred this issue from sourcegraph/sourcegraph-public-snapshot Apr 26, 2019
@felixfbecker felixfbecker added the good first issue Good for newcomers label Jun 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

3 participants