Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unable to index ILSpy #49

Open
varungandhi-src opened this issue Oct 18, 2023 · 1 comment
Open

Unable to index ILSpy #49

varungandhi-src opened this issue Oct 18, 2023 · 1 comment

Comments

@varungandhi-src
Copy link
Contributor

Reproduction steps:

git clone https://github.com/icsharpcode/ILSpy.git
cd ILSpy && git checkout d5cec0ab3
docker run -v $(pwd):/app sourcegraph/scip-dotnet:latest scip-dotnet index ILSpy.sln

scip-dotnet image hash: a4b074f00f73

image

There are a few different issues here:

  • The indexer shouldn't be running for over 10 minutes with no output after the dotnet restore timeout log line
  • The running dotnet restore command wasn't killed (it's still taking up 1 CPU). Assuming that the indexer is going to read files written by dotnet restore, this creates a race condition, so we should kill it if it times out.
  • There's only about 200k SLOC of C# in the repo, so it seems like 10 minutes is too long.
@varungandhi-src
Copy link
Contributor Author

When I installed scip-dotnet v0.1.15 globally on Linux (the previous approach was using Docker on macOS), I was able to index ILSpy without issues.

@linear linear bot closed this as not planned Won't fix, can't repro, duplicate, stale Nov 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant