PGDATASOURCE cannot use dependent environment variables

[uhthomas]

The additional environment variables are declared before the database environment variables which means the $() syntax will be interpreted literally.

deploy-sourcegraph-helm/charts/sourcegraph/templates/frontend/sourcegraph-frontend.Deployment.yaml

Lines 78 to 86 in 77d75fb

	env:
	{{- range $name, $item := .Values.frontend.env}}
	- name: {{ $name }}
	{{- $item | toYaml | nindent 10 }}
	{{- end }}
	{{- include "sourcegraph.databaseAuth" (list . "pgsql" "PG") | nindent 8 }}
	{{- include "sourcegraph.databaseAuth" (list . "codeIntelDB" "CODEINTEL_PG") | nindent 8 }}
	{{- include "sourcegraph.databaseAuth" (list . "codeInsightsDB" "CODEINSIGHTS_PG") | nindent 8 }}
	{{- include "sourcegraph.redisConnection" .| nindent 8 }}

When you create a Pod, you can set dependent environment variables for the containers that run in the Pod. To set dependent environment variables, you can use $(VAR_NAME) in the value of env in the configuration file.

...

When the environment variable is undefined or only includes some variables, the undefined environment variable is treated as a normal string, such as UNCHANGED_REFERENCE. Note that incorrectly parsed environment variables, in general, will not block the container from starting.

https://kubernetes.io/docs/tasks/inject-data-application/define-interdependent-environment-variables/#define-an-environment-dependent-variable-for-a-container